check_diff/src/lib.rs

use std::borrow::Cow;
use std::collections::HashMap;
use std::env;
use std::fmt::{Debug, Display};
use std::io::{self, Write};
use std::path::{Path, PathBuf};
use std::process::{Command, Stdio};
use std::str::FromStr;
use std::sync::{Arc, Mutex};
use tempfile::tempdir;
use tracing::{debug, info, trace, warn};
use walkdir::WalkDir;

#[derive(Debug, Clone, Copy)]
pub enum Edition {
    /// rust edition 2015
    Edition2015,
    /// rust edition 2018
    Edition2018,
    /// rust edition 2021
    Edition2021,
    /// rust edition 2024
    Edition2024,
}

impl Edition {
    fn as_str(&self) -> &str {
        match self {
            Edition::Edition2015 => "2015",
            Edition::Edition2018 => "2018",
            Edition::Edition2021 => "2021",
            Edition::Edition2024 => "2024",
        }
    }
}

impl FromStr for Edition {
    type Err = String;

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        match s {
            "2015" => Ok(Edition::Edition2015),
            "2018" => Ok(Edition::Edition2018),
            "2021" => Ok(Edition::Edition2021),
            "2024" => Ok(Edition::Edition2024),
            _ => Err(format!("Invalid rust language edition {s}")),
        }
    }
}

#[derive(Debug, Clone, Copy)]
pub enum StyleEdition {
    // rustfmt style_edition 2021. Also equivaluent to 2015 and 2018.
    Edition2021,
    // rustfmt style_edition 2024
    Edition2024,
}

impl StyleEdition {
    fn as_str(&self) -> &str {
        match self {
            StyleEdition::Edition2021 => "2021",
            StyleEdition::Edition2024 => "2024",
        }
    }
}

impl FromStr for StyleEdition {
    type Err = String;

    fn from_str(s: &str) -> Result<Self, Self::Err> {
        match s {
            "2015" => Ok(StyleEdition::Edition2021),
            "2018" => Ok(StyleEdition::Edition2021),
            "2021" => Ok(StyleEdition::Edition2021),
            "2024" => Ok(StyleEdition::Edition2024),
            _ => Err(format!("Invalid rustfmt style edition {s}")),
        }
    }
}

pub enum FormatCodeError {
    // IO Error when running code formatter
    Io(std::io::Error),
    /// An error occured that prevents code formatting. For example, a parse error.
    CodeNotFormatted(Vec<u8>),
}

impl From<std::io::Error> for FormatCodeError {
    fn from(error: std::io::Error) -> Self {
        Self::Io(error)
    }
}

impl std::fmt::Debug for FormatCodeError {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        match self {
            Self::Io(e) => std::fmt::Debug::fmt(e, f),
            Self::CodeNotFormatted(e) => {
                let data = String::from_utf8_lossy(e);
                f.write_str(&data)
            }
        }
    }
}

pub enum CreateDiffError {
    /// Couldn't create a diff because the rustfmt binary compiled from the `main` branch
    /// failed to format the input.
    MainRustfmtFailed(FormatCodeError),
    /// Couldn't create a diff because the rustfmt binary compiled from the `feature` branch
    /// failed to format the input.
    FeatureRustfmtFailed(FormatCodeError),
    /// Couldn't create a diff because both rustfmt binaries failed to format the input
    BothRustfmtFailed {
        src: FormatCodeError,
        feature: FormatCodeError,
    },
}

#[derive(Debug)]
pub enum CheckDiffError {
    /// Git related errors
    FailedGit(GitError),
    /// Error for generic commands
    FailedCommand(&'static str),
    /// Error for building rustfmt from source
    FailedSourceBuild(&'static str),
    /// Error when obtaining binary version
    FailedBinaryVersioning(PathBuf),
    /// Error when obtaining cargo version
    FailedCargoVersion(&'static str),
    IO(std::io::Error),
}

impl From<io::Error> for CheckDiffError {
    fn from(error: io::Error) -> Self {
        CheckDiffError::IO(error)
    }
}

impl From<GitError> for CheckDiffError {
    fn from(error: GitError) -> Self {
        CheckDiffError::FailedGit(error)
    }
}

#[derive(Debug)]
pub enum GitError {
    FailedClone { stdout: Vec<u8>, stderr: Vec<u8> },
    FailedRemoteAdd { stdout: Vec<u8>, stderr: Vec<u8> },
    FailedFetch { stdout: Vec<u8>, stderr: Vec<u8> },
    FailedSwitch { stdout: Vec<u8>, stderr: Vec<u8> },
    IO(std::io::Error),
}

impl From<io::Error> for GitError {
    fn from(error: io::Error) -> Self {
        GitError::IO(error)
    }
}

pub struct Diff {
    src_format: String,
    feature_format: String,
}

impl Display for Diff {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        let patch = diffy::create_patch(self.src_format.as_str(), self.feature_format.as_str());
        write!(f, "{}", patch)
    }
}

impl Diff {
    pub fn is_empty(&self) -> bool {
        let patch = diffy::create_patch(self.src_format.as_str(), self.feature_format.as_str());
        patch.hunks().is_empty()
    }
}

pub struct CheckDiffRunners<F, S> {
    feature_runner: F,
    src_runner: S,
}

pub trait CodeFormatter {
    fn format_code(&self, code: &str) -> Result<String, FormatCodeError>;

    fn format_code_from_path<P: AsRef<Path>>(&self, path: P) -> Result<String, FormatCodeError> {
        let code = std::fs::read_to_string(path)?;
        self.format_code(&code)
    }
}

pub struct RustfmtRunner {
    dynamic_library_path: String,
    binary_path: PathBuf,
    edition: Edition,
    style_edition: StyleEdition,
    config: Cow<'static, str>,
}

impl<F, S> CheckDiffRunners<F, S> {
    pub fn new(feature_runner: F, src_runner: S) -> Self {
        Self {
            feature_runner,
            src_runner,
        }
    }
}

impl<F, S> CheckDiffRunners<F, S>
where
    F: CodeFormatter,
    S: CodeFormatter,
{
    /// Creates a diff generated by running the source and feature binaries on the same file path
    pub fn create_diff<P: AsRef<Path>>(&self, path: P) -> Result<Diff, CreateDiffError> {
        let src_format = self.src_runner.format_code_from_path(&path);
        let feature_format = self.feature_runner.format_code_from_path(&path);

        match (src_format, feature_format) {
            (Ok(s), Ok(f)) => Ok(Diff {
                src_format: s,
                feature_format: f,
            }),
            (Err(error), Ok(_)) => {
                // main formatting failed.
                Err(CreateDiffError::MainRustfmtFailed(error))
            }
            (Ok(_), Err(error)) => {
                // feature formatting failed
                Err(CreateDiffError::FeatureRustfmtFailed(error))
            }
            (Err(src_error), Err(feature_error)) => {
                // Both main formatting and feature formatting failed
                Err(CreateDiffError::BothRustfmtFailed {
                    src: src_error,
                    feature: feature_error,
                })
            }
        }
    }
}

impl RustfmtRunner {
    fn get_binary_version(&self) -> Result<String, CheckDiffError> {
        let Ok(command) = Command::new(&self.binary_path)
            .env(
                dynamic_library_path_env_var_name(),
                &self.dynamic_library_path,
            )
            .args(["--version"])
            .output()
        else {
            return Err(CheckDiffError::FailedBinaryVersioning(
                self.binary_path.clone(),
            ));
        };

        Ok(buffer_into_utf8_lossy(command.stdout))
    }

    fn command_line_configs(&self) -> &str {
        &self.config
    }
}

/// Convert a buffer of u8 into a String.
fn buffer_into_utf8_lossy(buffer: Vec<u8>) -> String {
    let mut s = match String::from_utf8(buffer) {
        Ok(s) => s,
        Err(e) => String::from_utf8_lossy(e.as_bytes()).to_string(),
    };
    s.truncate(s.trim_end().len());
    s
}

/// Returns the name of the environment variable used to search for dynamic libraries.
/// This is the same logic that cargo uses when setting these environment variables
fn dynamic_library_path_env_var_name() -> &'static str {
    if cfg!(windows) {
        "PATH"
    } else if cfg!(target_os = "macos") {
        "DYLD_FALLBACK_LIBRARY_PATH"
    } else if cfg!(target_os = "aix") {
        "LIBPATH"
    } else {
        "LD_LIBRARY_PATH"
    }
}

impl CodeFormatter for RustfmtRunner {
    // When rustfmt knows the file path it's able to skip formatting for files listed in the repo's
    // rustfmt.toml `ignore` list. For example, this helps us skip files in r-l/rust that have
    // been explicitly skipped because trying to format them causes rustfmt to hang or rustfmt.
    // doesn't do a good job at formatting those files.
    fn format_code_from_path<P: AsRef<Path>>(&self, path: P) -> Result<String, FormatCodeError> {
        let command = Command::new(&self.binary_path)
            .env(
                dynamic_library_path_env_var_name(),
                &self.dynamic_library_path,
            )
            .args([
                "--edition",
                self.edition.as_str(),
                "--style-edition",
                self.style_edition.as_str(),
                "--unstable-features",
                "--skip-children",
                "--emit=stdout",
                self.command_line_configs(),
            ])
            .arg(path.as_ref())
            .stdin(Stdio::piped())
            .stdout(Stdio::piped())
            .stderr(Stdio::piped())
            .spawn()?;

        let output = command.wait_with_output()?;
        let formatted_code = buffer_into_utf8_lossy(output.stdout);

        match output.status.code() {
            Some(0) => Ok(formatted_code),
            Some(_) | None => {
                if !formatted_code.is_empty() {
                    Ok(formatted_code)
                } else {
                    Err(FormatCodeError::CodeNotFormatted(output.stderr))
                }
            }
        }
    }

    //  Run rusfmt to see if a diff is produced. Runs on the code specified
    //
    // Parameters:
    // code: Code to run the binary on
    // config: Any additional configuration options to pass to rustfmt
    //
    fn format_code(&self, code: &str) -> Result<String, FormatCodeError> {
        let mut command = Command::new(&self.binary_path)
            .env(
                dynamic_library_path_env_var_name(),
                &self.dynamic_library_path,
            )
            .args([
                "--edition",
                self.edition.as_str(),
                "--style-edition",
                self.style_edition.as_str(),
                "--unstable-features",
                "--skip-children",
                "--emit=stdout",
                self.command_line_configs(),
            ])
            .stdin(Stdio::piped())
            .stdout(Stdio::piped())
            .stderr(Stdio::piped())
            .spawn()?;

        command.stdin.as_mut().unwrap().write_all(code.as_bytes())?;
        let output = command.wait_with_output()?;
        let formatted_code = buffer_into_utf8_lossy(output.stdout);

        match output.status.code() {
            Some(0) => Ok(formatted_code),
            Some(_) | None => {
                if !formatted_code.is_empty() {
                    Ok(formatted_code)
                } else {
                    Err(FormatCodeError::CodeNotFormatted(output.stderr))
                }
            }
        }
    }
}

const DEFAULT_CONFIG: &str = "--config=error_on_line_overflow=false,error_on_unformatted=false";

/// Creates a configuration in the following form:
/// <config_name>=<config_val>, <config_name>=<config_val>, ...
fn create_config_arg<T: AsRef<str>>(configs: Option<&[T]>) -> Cow<'static, str> {
    let Some(configs) = configs else {
        return Cow::Borrowed(DEFAULT_CONFIG);
    };

    let mut configs_len = 0;
    let mut num_configs = 0;

    // Determine how many non empty configs we've got
    for c in configs.iter().map(AsRef::as_ref) {
        if c.is_empty() {
            continue;
        }

        configs_len += c.len();
        num_configs += 1;
    }

    if num_configs == 0 {
        // All configs were empty so return the default.
        return Cow::Borrowed(DEFAULT_CONFIG);
    }

    // We need capacity for the default configs len + one ',' per config + total config element len
    let mut result = String::with_capacity(DEFAULT_CONFIG.len() + num_configs + configs_len);

    for c in configs.iter().map(AsRef::as_ref) {
        result.push(',');
        result.push_str(c);
    }

    Cow::Owned(result)
}

pub struct Repository<P> {
    /// Name of the repository
    name: String,
    /// Path to the repository on the local file system
    dir_path: P,
}

impl<P> Repository<P> {
    /// Initialize a new Repository
    pub fn new(git_url: &str, dir_path: P) -> Self {
        let name = get_repo_name(git_url).to_string();
        Self { name, dir_path }
    }

    /// Get the `name` of the repository
    pub fn name(&self) -> &str {
        &self.name
    }

    /// Get the absolute path to where this repository was cloned
    pub fn path(&self) -> &Path
    where
        P: AsRef<Path>,
    {
        self.dir_path.as_ref()
    }

    /// Get the relative path of a file contained in this repository
    pub fn relative_path<'f, F>(&self, file: &'f F) -> &'f Path
    where
        P: AsRef<Path>,
        F: AsRef<Path>,
    {
        file.as_ref()
            .strip_prefix(self.dir_path.as_ref())
            .unwrap_or(file.as_ref())
    }
}

/// Clone a git repository
///
/// Parameters:
/// url: git clone url
/// dest: directory where the repo should be cloned
pub fn clone_git_repo(url: &str, dest: &Path) -> Result<(), GitError> {
    let git_cmd = Command::new("git")
        .env("GIT_TERMINAL_PROMPT", "0")
        .args([
            "clone",
            "--quiet",
            url,
            "--depth",
            "1",
            dest.to_str().unwrap(),
        ])
        .output()?;

    // if the git command does not return successfully,
    // any command on the repo will fail. So fail fast.
    if !git_cmd.status.success() {
        let error = GitError::FailedClone {
            stdout: git_cmd.stdout,
            stderr: git_cmd.stderr,
        };
        return Err(error);
    }

    info!("Successfully cloned repository {url} to {}", dest.display());
    Ok(())
}

pub fn git_remote_add(url: &str) -> Result<(), GitError> {
    let git_cmd = Command::new("git")
        .args(["remote", "add", "feature", url])
        .output()?;

    // if the git command does not return successfully,
    // any command on the repo will fail. So fail fast.
    if !git_cmd.status.success() {
        let error = GitError::FailedRemoteAdd {
            stdout: git_cmd.stdout,
            stderr: git_cmd.stderr,
        };
        return Err(error);
    }

    info!("Successfully added remote: {url}");
    Ok(())
}

pub fn git_fetch(branch_name: &str) -> Result<(), GitError> {
    let git_cmd = Command::new("git")
        .args(["fetch", "feature", branch_name])
        .output()?;

    // if the git command does not return successfully,
    // any command on the repo will fail. So fail fast.
    if !git_cmd.status.success() {
        let error = GitError::FailedFetch {
            stdout: git_cmd.stdout,
            stderr: git_cmd.stderr,
        };
        return Err(error);
    }

    info!("Successfully fetched: {branch_name}");
    Ok(())
}

pub fn git_switch(git_ref: &str, should_detach: bool) -> Result<(), GitError> {
    let detach_arg = if should_detach { "--detach" } else { "" };
    let args = ["switch", git_ref, detach_arg];
    let output = Command::new("git")
        .args(args.iter().filter(|arg| !arg.is_empty()))
        .output()?;
    if !output.status.success() {
        tracing::error!("Git switch failed: {output:?}");
        let error = GitError::FailedSwitch {
            stdout: output.stdout,
            stderr: output.stderr,
        };
        return Err(error);
    }
    info!("Successfully switched to {git_ref}");
    Ok(())
}

pub fn change_directory_to_path(dest: &Path) -> io::Result<()> {
    let dest_path = Path::new(&dest);
    env::set_current_dir(dest_path)?;
    info!(
        "Setting current directory to: {}",
        env::current_dir().unwrap().display()
    );
    Ok(())
}

pub fn get_dynamic_library_path(dir: &Path) -> Result<String, CheckDiffError> {
    let Ok(command) = Command::new("rustc")
        .current_dir(dir)
        .args(["--print", "sysroot"])
        .output()
    else {
        return Err(CheckDiffError::FailedCommand("Error getting sysroot"));
    };
    let mut sysroot = buffer_into_utf8_lossy(command.stdout);
    sysroot.push_str("/lib");
    Ok(sysroot)
}

pub fn get_cargo_version() -> Result<String, CheckDiffError> {
    let Ok(command) = Command::new("cargo").args(["--version"]).output() else {
        return Err(CheckDiffError::FailedCargoVersion(
            "Failed to obtain cargo version",
        ));
    };

    Ok(buffer_into_utf8_lossy(command.stdout))
}

/// Obtains the ld_lib path and then builds rustfmt from source
/// If that operation succeeds, the source is then copied to the output path specified
pub fn build_rustfmt_from_src<T: AsRef<str>>(
    binary_path: PathBuf,
    dir: &Path,
    edition: Edition,
    style_edition: StyleEdition,
    config: Option<&[T]>,
) -> Result<RustfmtRunner, CheckDiffError> {
    // Because we're building standalone binaries we need to set the dynamic library path
    // so each rustfmt binary can find it's runtime dependencies.
    let dynamic_library_path = get_dynamic_library_path(dir)?;

    info!("Building rustfmt from source");
    let Ok(_) = Command::new("cargo")
        .current_dir(dir)
        .args(["build", "-q", "--release", "--bin", "rustfmt"])
        .output()
    else {
        return Err(CheckDiffError::FailedSourceBuild(
            "Error building rustfmt from source",
        ));
    };

    std::fs::copy(dir.join("target/release/rustfmt"), &binary_path)?;

    Ok(RustfmtRunner {
        dynamic_library_path,
        binary_path,
        edition,
        style_edition,
        config: create_config_arg(config),
    })
}

// Compiles and produces two rustfmt binaries.
// One for the current main branch, and another for the feature branch
// Parameters:
// dest: Directory where rustfmt will be cloned
pub fn compile_rustfmt<T: AsRef<str>>(
    dest: &Path,
    remote_repo_url: String,
    feature_branch: String,
    edition: Edition,
    style_edition: StyleEdition,
    commit_hash: Option<String>,
    config: Option<&[T]>,
) -> Result<CheckDiffRunners<RustfmtRunner, RustfmtRunner>, CheckDiffError> {
    const RUSTFMT_REPO: &str = "https://github.com/rust-lang/rustfmt.git";

    clone_git_repo(RUSTFMT_REPO, dest)?;
    change_directory_to_path(dest)?;
    git_remote_add(remote_repo_url.as_str())?;
    git_fetch(feature_branch.as_str())?;

    let cargo_version = get_cargo_version()?;
    info!("Compiling with {}", cargo_version);
    let src_runner = build_rustfmt_from_src(
        dest.join("src_rustfmt"),
        dest,
        edition,
        style_edition,
        config,
    )?;
    let should_detach = commit_hash.is_some();
    git_switch(
        commit_hash.as_ref().unwrap_or(&feature_branch),
        should_detach,
    )?;

    let feature_runner = build_rustfmt_from_src(
        dest.join("feature_rustfmt"),
        dest,
        edition,
        style_edition,
        config,
    )?;
    info!("RUSFMT_BIN {}", src_runner.get_binary_version()?);
    let dynamic_library_path_env_var = dynamic_library_path_env_var_name();
    info!(
        "Runtime dependencies for (main) rustfmt -- {}: {}",
        dynamic_library_path_env_var, src_runner.dynamic_library_path
    );
    info!("FEATURE_BIN {}", feature_runner.get_binary_version()?);
    info!(
        "Runtime dependencies for ({}) rustfmt -- {}: {}",
        feature_branch, dynamic_library_path_env_var, feature_runner.dynamic_library_path
    );

    Ok(CheckDiffRunners {
        src_runner,
        feature_runner,
    })
}

/// Searches for rust files in the particular path and returns an iterator to them.
pub fn search_for_rs_files(repo: &Path) -> impl Iterator<Item = PathBuf> {
    WalkDir::new(repo).into_iter().filter_map(|e| match e.ok() {
        Some(entry) => {
            let path = entry.path();
            if path.is_file() && path.extension().is_some_and(|ext| ext == "rs") {
                return Some(entry.into_path());
            }
            None
        }
        None => None,
    })
}

/// Encapsulate the logic used to clone repositories for the diff check
pub fn clone_repositories_for_diff_check(
    repositories: &[&str],
) -> Vec<Repository<tempfile::TempDir>> {
    // Use a Hashmap to deduplicate any repositories
    let map = Arc::new(Mutex::new(HashMap::new()));

    std::thread::scope(|s| {
        for url in repositories {
            let map = Arc::clone(&map);

            s.spawn(move || {
                let repo_name = get_repo_name(url);
                info!("Processing repo: {repo_name}");
                let Ok(tmp_dir) = tempdir() else {
                    warn!(
                        "Failed to create a tempdir for {}. Can't check formatting diff for {}",
                        &url, repo_name
                    );
                    return;
                };

                let Ok(_) = clone_git_repo(url, tmp_dir.path()) else {
                    warn!(
                        "Failed to clone repo {}. Can't check formatting diff for {}",
                        &url, repo_name
                    );
                    return;
                };

                let repo = Repository::new(url, tmp_dir);
                map.lock().unwrap().insert(repo_name.to_string(), repo);
            });
        }
    });

    let map = match Arc::into_inner(map)
        .expect("All other threads are done")
        .into_inner()
    {
        Ok(map) => map,
        Err(e) => e.into_inner(),
    };

    map.into_values().collect()
}

/// Calculates the number of errors when running the compiled binary and the feature binary on the
/// repo specified with the specific configs.
pub fn check_diff_for_file<'repo, P: AsRef<Path>, F: AsRef<Path>>(
    runners: &CheckDiffRunners<impl CodeFormatter, impl CodeFormatter>,
    repo: &'repo Repository<P>,
    file: F,
) -> Result<(), (Diff, F, &'repo Repository<P>)> {
    let relative_path = repo.relative_path(&file);
    let repo_name = repo.name();

    trace!(
        "Formatting '{0}' file {0}/{1}",
        repo_name,
        relative_path.display()
    );

    match runners.create_diff(file.as_ref()) {
        Ok(diff) => {
            if !diff.is_empty() {
                Err((diff, file, repo))
            } else {
                trace!(
                    "No diff found in '{0}' when formatting {0}/{1}",
                    repo_name,
                    relative_path.display(),
                );
                Ok(())
            }
        }
        Err(CreateDiffError::MainRustfmtFailed(e)) => {
            debug!(
                "`main` rustfmt failed to format {}/{}\n{:?}",
                repo_name,
                relative_path.display(),
                e,
            );
            Ok(())
        }
        Err(CreateDiffError::FeatureRustfmtFailed(e)) => {
            debug!(
                "`feature` rustfmt failed to format {}/{}\n{:?}",
                repo_name,
                relative_path.display(),
                e,
            );
            Ok(())
        }
        Err(CreateDiffError::BothRustfmtFailed { src, feature }) => {
            debug!(
                "Both rustfmt binaries failed to format {}/{}\n{:?}\n{:?}",
                repo_name,
                relative_path.display(),
                src,
                feature,
            );
            Ok(())
        }
    }
}

/// parse out the repository name from a GitHub Repository name.
pub fn get_repo_name(git_url: &str) -> &str {
    let strip_git_prefix = git_url.strip_suffix(".git").unwrap_or(git_url);
    let (_, repo_name) = strip_git_prefix
        .rsplit_once('/')
        .unwrap_or(("", strip_git_prefix));
    repo_name
}

pub fn check_diff<'repo, P, F, M>(
    runners: &CheckDiffRunners<F, M>,
    repositories: &'repo [Repository<P>],
    worker_threads: std::num::NonZeroU8,
) -> Vec<(Diff, PathBuf, &'repo Repository<P>)>
where
    P: AsRef<Path> + Sync + Send,
    F: CodeFormatter + Sync,
    M: CodeFormatter + Sync,
{
    let (tx, rx) = crossbeam_channel::unbounded();

    let errors = std::thread::scope(|s| {
        // Spawn producer threads that find files to check
        for repo in repositories.iter() {
            let tx = tx.clone();
            s.spawn(move || {
                for file in search_for_rs_files(repo.path()) {
                    let _ = tx.send((file, repo));
                }
            });
        }

        // Drop the first `tx` we created. Now there's exactly one `tx` per producer thread so when
        // each producer thread finishes the receiving threads will start to get Err(RecvError)
        // when calling `rx.recv()` and they'll know to stop processing files.
        // When all scoped threads end we'll know we're done with processing and we can return
        // any errors we found to the caller.
        drop(tx);

        let errors = Arc::new(Mutex::new(Vec::with_capacity(10)));

        // spawn receiver threads used to process all files:
        for _ in 0..u8::from(worker_threads) {
            let errors = Arc::clone(&errors);
            let rx = rx.clone();
            s.spawn(move || {
                while let Ok((file, repo)) = rx.recv() {
                    if let Err(e) = check_diff_for_file(runners, repo, file) {
                        // Push errors to report on later
                        errors.lock().unwrap().push(e);
                    }
                }
            });
        }
        errors
    });

    match Arc::into_inner(errors)
        .expect("All other threads are done")
        .into_inner()
    {
        Ok(e) => e,
        Err(e) => e.into_inner(),
    }
}