blob: d8f6239764d133190cd5a874c27fb8395dc2df70 [file] [log] [blame]
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:32:5
|
LL | x.field.map(do_nothing);
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `-D clippy::result-map-unit-fn` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::result_map_unit_fn)]`
help: use `if let` instead
|
LL - x.field.map(do_nothing);
LL + if let Ok(x_field) = x.field { do_nothing(x_field) }
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:35:5
|
LL | x.field.map(do_nothing);
| ^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(do_nothing);
LL + if let Ok(x_field) = x.field { do_nothing(x_field) }
|
error: called `map(f)` on an `Result` value where `f` is a function that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:38:5
|
LL | x.field.map(diverge);
| ^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(diverge);
LL + if let Ok(x_field) = x.field { diverge(x_field) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:45:5
|
LL | x.field.map(|value| x.do_result_nothing(value + captured));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| x.do_result_nothing(value + captured));
LL + if let Ok(value) = x.field { x.do_result_nothing(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:48:5
|
LL | x.field.map(|value| { x.do_result_plus_one(value + captured); });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { x.do_result_plus_one(value + captured); });
LL + if let Ok(value) = x.field { x.do_result_plus_one(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:52:5
|
LL | x.field.map(|value| do_nothing(value + captured));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| do_nothing(value + captured));
LL + if let Ok(value) = x.field { do_nothing(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:55:5
|
LL | x.field.map(|value| { do_nothing(value + captured) });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { do_nothing(value + captured) });
LL + if let Ok(value) = x.field { do_nothing(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:58:5
|
LL | x.field.map(|value| { do_nothing(value + captured); });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { do_nothing(value + captured); });
LL + if let Ok(value) = x.field { do_nothing(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:61:5
|
LL | x.field.map(|value| { { do_nothing(value + captured); } });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { { do_nothing(value + captured); } });
LL + if let Ok(value) = x.field { do_nothing(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:65:5
|
LL | x.field.map(|value| diverge(value + captured));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| diverge(value + captured));
LL + if let Ok(value) = x.field { diverge(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:68:5
|
LL | x.field.map(|value| { diverge(value + captured) });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { diverge(value + captured) });
LL + if let Ok(value) = x.field { diverge(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:71:5
|
LL | x.field.map(|value| { diverge(value + captured); });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { diverge(value + captured); });
LL + if let Ok(value) = x.field { diverge(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:74:5
|
LL | x.field.map(|value| { { diverge(value + captured); } });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { { diverge(value + captured); } });
LL + if let Ok(value) = x.field { diverge(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:80:5
|
LL | x.field.map(|value| { let y = plus_one(value + captured); });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { let y = plus_one(value + captured); });
LL + if let Ok(value) = x.field { let y = plus_one(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:83:5
|
LL | x.field.map(|value| { plus_one(value + captured); });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { plus_one(value + captured); });
LL + if let Ok(value) = x.field { plus_one(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:86:5
|
LL | x.field.map(|value| { { plus_one(value + captured); } });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| { { plus_one(value + captured); } });
LL + if let Ok(value) = x.field { plus_one(value + captured); }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:90:5
|
LL | x.field.map(|ref value| { do_nothing(value + captured) });
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|ref value| { do_nothing(value + captured) });
LL + if let Ok(ref value) = x.field { do_nothing(value + captured) }
|
error: called `map(f)` on an `Result` value where `f` is a closure that returns the unit type `()`
--> tests/ui/result_map_unit_fn_fixable.rs:93:5
|
LL | x.field.map(|value| println!("{value:?}"));
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
help: use `if let` instead
|
LL - x.field.map(|value| println!("{value:?}"));
LL + if let Ok(value) = x.field { println!("{value:?}") }
|
error: aborting due to 18 previous errors