| use clippy_utils::diagnostics::span_lint_and_help; | |
| use clippy_utils::res::{MaybeDef, MaybeTypeckRes}; | |
| use rustc_hir as hir; | |
| use rustc_lint::LateContext; | |
| use rustc_span::{Span, sym}; | |
| use super::INSPECT_FOR_EACH; | |
| /// lint use of `inspect().for_each()` for `Iterators` | |
| pub(super) fn check<'tcx>(cx: &LateContext<'tcx>, expr: &'tcx hir::Expr<'_>, inspect_span: Span) { | |
| if cx.ty_based_def(expr).opt_parent(cx).is_diag_item(cx, sym::Iterator) { | |
| let msg = "called `inspect(..).for_each(..)` on an `Iterator`"; | |
| let hint = "move the code from `inspect(..)` to `for_each(..)` and remove the `inspect(..)`"; | |
| span_lint_and_help( | |
| cx, | |
| INSPECT_FOR_EACH, | |
| inspect_span.with_hi(expr.span.hi()), | |
| msg, | |
| None, | |
| hint, | |
| ); | |
| } | |
| } |