Rollup merge of #159855 - valentynkit:pidfd-wait-eintr, r=Mark-Simulacrum
std: retry waitid on EINTR in the pidfd wait path
The pidfd-backed `Child::wait()` and `try_wait()` share a `waitid` helper that calls `waitid` through plain `cvt`, so an `EINTR` reaches the caller as `ErrorKind::Interrupted`. The legacy `waitpid` path that the pidfd path stands in for retries instead: `wait()` there uses `cvt_r`. So a child spawned with a pidfd can see `Interrupted` from `wait()` where the same call without one wouldn't.
Both callers go through the one helper, so this wraps the `waitid` call in `cvt_r` to match the legacy `wait()`:
```rust
let r = cvt_r(|| unsafe {
libc::waitid(libc::P_PIDFD, self.0.as_raw_fd() as u32, &mut siginfo, options)
});
```
For the blocking `wait()` that's the fix. `try_wait()` passes `WNOHANG`, and `waitid` only returns `EINTR` when it isn't set, from
[`wait(2)`](https://www.man7.org/linux/man-pages/man2/wait.2.html#ERRORS):
> EINTR WNOHANG was not set and an unblocked signal or a SIGCHLD was caught; see signal(7).
I didn't add a test, since landing an `EINTR` in the wait window needs a signal to arrive at the right moment and isn't practical to reproduce.
r? libs
Website | Getting started | Learn | Documentation | Contributing
This is the main source code repository for Rust. It contains the compiler, standard library, and documentation.
Performance: Fast and memory-efficient, suitable for critical services, embedded devices, and easily integrated with other languages.
Reliability: Our rich type system and ownership model ensure memory and thread safety, reducing bugs at compile-time.
Productivity: Comprehensive documentation, a compiler committed to providing great diagnostics, and advanced tooling including package manager and build tool (Cargo), auto-formatter (rustfmt), linter (Clippy) and editor support (rust-analyzer).
Read “Installation” from The Book.
If you really want to install from source (though this is not recommended), see INSTALL.md.
See https://www.rust-lang.org/community for a list of chat platforms and forums.
See CONTRIBUTING.md.
For a detailed explanation of the compiler's architecture and how to begin contributing, see the rustc-dev-guide.
Rust is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0), with portions covered by various BSD-like licenses.
See LICENSE-APACHE, LICENSE-MIT, and COPYRIGHT for details.
The Rust Foundation owns and protects the Rust and Cargo trademarks and logos (the “Rust Trademarks”).
If you want to use these names or brands, please read the Rust language trademark policy.
Third-party logos may be subject to third-party copyrights and trademarks. See Licenses for details.