Rollup merge of #161467 - Dnreikronos:wfcheck/unused_param_name_discarding_item, r=fmease

wfcheck: name the item that discards an unused type parameter

fixes rust-lang/rust#161365

label was "`T` is named here, but is likely unused in the containing type". the "likely" is the part that bugs me. we can just go look, so now it does:

```
LL |     bar: Bar<T>,
   |              - `T` is named here, but `Bar` does not use it
```

while collecting the usage spans it holds on to the outermost thing that throws the argument away. adts are easy, bivariant param in variances_of. aliases have no variances so you expand them and see what's left, and my first version of that only looked for the param in the rhs, which is wrong. `type Alias<T> = DropFirst<T, u8>` mentions T and still drops it. so it walks the expansion skipping bivariant slots. (nested args blame the outer one, `Bar<Vec<T>>` points at Bar.) if it can't work out who's responsible it falls back to "this does not constrain `T`".

warning for whoever touches this next: type_of doesn't expand free aliases and you can't chase them yourself. `type Recur<T> = Recur<(T,)>` never repeats its args so there's nothing to stop on, stack goes. expand_free_alias_tys is the one with the limit. variance-overflow.rs has a comment at the top saying exactly this and i wrote it wrong anyway, so i stuck a case in there for the diagnostic path.

tests in variance-unused-type-param.rs, new file for alias chains.

there's a separate bug in the "only used recursively" branch right next to this one that i left alone, wrote up why in a comment.
tree: 69c92120c122cc89b7d8d878d3159972ae229522
  1. .github/
  2. compiler/
  3. library/
  4. LICENSES/
  5. src/
  6. tests/
  7. .clang-format
  8. .editorconfig
  9. .git-blame-ignore-revs
  10. .gitattributes
  11. .gitignore
  12. .gitmodules
  13. .ignore
  14. .mailmap
  15. AGENTS.md
  16. bootstrap.example.toml
  17. Cargo.lock
  18. Cargo.toml
  19. CLAUDE.md
  20. CODE_OF_CONDUCT.md
  21. configure
  22. CONTRIBUTING.md
  23. COPYRIGHT
  24. INSTALL.md
  25. LICENSE-APACHE
  26. license-metadata.json
  27. LICENSE-MIT
  28. package.json
  29. README.md
  30. RELEASES.md
  31. REUSE.toml
  32. rust-bors.toml
  33. rustfmt.toml
  34. triagebot.toml
  35. typos.toml
  36. x
  37. x.ps1
  38. x.py
  39. yarn.lock
README.md

Website | Getting started | Learn | Documentation | Contributing

This is the main source code repository for Rust. It contains the compiler, standard library, and documentation.

Why Rust?

  • Performance: Fast and memory-efficient, suitable for critical services, embedded devices, and easily integrated with other languages.

  • Reliability: Our rich type system and ownership model ensure memory and thread safety, reducing bugs at compile-time.

  • Productivity: Comprehensive documentation, a compiler committed to providing great diagnostics, and advanced tooling including package manager and build tool (Cargo), auto-formatter (rustfmt), linter (Clippy) and editor support (rust-analyzer).

Quick Start

Read “Installation” from The Book.

Installing from Source

If you really want to install from source (though this is not recommended), see INSTALL.md.

Getting Help

See https://www.rust-lang.org/community for a list of chat platforms and forums.

Contributing

See CONTRIBUTING.md.

For a detailed explanation of the compiler's architecture and how to begin contributing, see the rustc-dev-guide.

License

Rust is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0), with portions covered by various BSD-like licenses.

See LICENSE-APACHE, LICENSE-MIT, and COPYRIGHT for details.

Trademark

The Rust Foundation owns and protects the Rust and Cargo trademarks and logos (the “Rust Trademarks”).

If you want to use these names or brands, please read the Rust language trademark policy.

Third-party logos may be subject to third-party copyrights and trademarks. See Licenses for details.