)]}'
{
  "commit": "0f6dae4afc8959262e7245fddfbdfc7a1de6f34a",
  "tree": "b0222948606a1ad650ad8ba1a30b7f86f8119e88",
  "parents": [
    "7934bbdf84a6b9a30297caf4f4f38286dedf876a",
    "47523223436d870e921d660bfa7441be58509b38"
  ],
  "author": {
    "name": "bors",
    "email": "bors@rust-lang.org",
    "time": "Tue Nov 25 13:51:31 2025 +0000"
  },
  "committer": {
    "name": "bors",
    "email": "bors@rust-lang.org",
    "time": "Tue Nov 25 13:51:31 2025 +0000"
  },
  "message": "Auto merge of #148122 - saethlin:deny-deref-nullptr, r\u003dpetrochenkov\n\nMake deref_nullptr deny by default instead of warn\n\nThis lint was added 4 years ago in https://github.com/rust-lang/rust/pull/83948 and I cannot find any discussion on that PR or its issue about whether it should be warn or deny by default.\n\nI think keeping this lint to warn was at one point in the past justifiable because of the old bindgen behavior of generating tests that do null pointer derefs. I\u0027ve certainly heard that argument. I don\u0027t think it holds up now, so I think we should be more firm about code that is definitely UB.\n\nWe merged https://github.com/rust-lang/rust/pull/134424 which adds a runtime check for null pointer reads/writes, with very little fanfare. So now we know things like: This lint warns on 111 crates in crater, but 106 crates are encountering the runtime UB check. 65 crates hit both the lint and a runtime check. Of the 46 crates that only hit the lint, 25 look to me like machine-generated bindings, and all hits except https://github.com/Plecra/asm-w-ownership/blob/3a0eff4bd151d8a0ccc076d6b8dea0bbc051e8e8/src/main.rs#L454 are trying to compute a field offset, and should use `offset_of!`.\n\nBased on the contents of the crater runs for 1.91, I\u0027d expect these crates to go from test-fail to build-fail as a result of this change:\n```\ngh/bernardjason/rust-invaders\ngh/Leinnan/doppler\ngh/Max-E/rust-gl-python-gtk\ngh/nslebruh/rust-opengl-glfw\ngh/nslebruh/rust_physics_gl_test\ngh/oraoto/php-stacktrace\ngh/playXE/jsrs\ngh/Plecra/asm-w-ownership\ngh/TateKennington/ROpenGL\ngh/WillFarris/voxel-game\nreg/ochre\n```\nMost of the crates where the lint fires already don\u0027t build for other reasons (note there are a lot of C bindings wrapper crates in the set).\n",
  "tree_diff": []
}