Rollup merge of #162946 - nnethercote:simplify-query-stack-printing, r=estebank
Simplify query stack printing
Currently it uses `eprintln!` for the "query stack during panic" header and "end of query stack" footer and
`struct_failure_note(..).with_span(..).emit()` for the stack frames. The difference is curious.
Looking more closely:
- failure notes lack a leading label (e.g. no "note: ");
- although the failure note is given a span, the span never renders because the `AnnotateSnippetEmitter` used for the query stack has an empty source map field;
- the JSON emitter is never involved here.
Therefore, the only difference between using `struct_failure_note` and `eprintln!` is that the former prints in bold. But boldness for frames isn't important; indeed, normal backtrace frames don't use bold.
So the commit changes query stack frame printing to use `eprintln!`, removes some now unnecessary `dcx` arguments, and also removes `struct_failure_note`. That leaves "For more information about an error, try `rustc --explain {}`" as the only use of `FailureNote`.
r? @estebank
Website | Getting started | Learn | Documentation | Contributing
This is the main source code repository for Rust. It contains the compiler, standard library, and documentation.
Performance: Fast and memory-efficient, suitable for critical services, embedded devices, and easily integrated with other languages.
Reliability: Our rich type system and ownership model ensure memory and thread safety, reducing bugs at compile-time.
Productivity: Comprehensive documentation, a compiler committed to providing great diagnostics, and advanced tooling including package manager and build tool (Cargo), auto-formatter (rustfmt), linter (Clippy) and editor support (rust-analyzer).
Read “Installation” from The Book.
If you really want to install from source (though this is not recommended), see INSTALL.md.
See https://www.rust-lang.org/community for a list of chat platforms and forums.
See CONTRIBUTING.md.
For a detailed explanation of the compiler's architecture and how to begin contributing, see the rustc-dev-guide.
Rust is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0), with portions covered by various BSD-like licenses.
See LICENSE-APACHE, LICENSE-MIT, and COPYRIGHT for details.
The Rust Foundation owns and protects the Rust and Cargo trademarks and logos (the “Rust Trademarks”).
If you want to use these names or brands, please read the Rust language trademark policy.
Third-party logos may be subject to third-party copyrights and trademarks. See Licenses for details.