| commit | cf622c4be3c798518862bf805d0b976f4a9026f9 | [log] [tgz] |
|---|---|---|
| author | Weihang Lo <weihanglo@users.noreply.github.com> | Sat Dec 27 14:28:13 2025 +0000 |
| committer | GitHub <noreply@github.com> | Sat Dec 27 14:28:13 2025 +0000 |
| tree | 1b95e48d3146f54554e9bba7bd00362d32a58f6e | |
| parent | 94c368ad2b9db0f0da5bdd8421cea13786ce4412 [diff] | |
| parent | 4c6f5a61ab4b5ee93fb792a63e0815eb49b92bf6 [diff] |
fix(vendor): recursively filter git files in subdirectories (#16439) ### What does this PR try to resolve? Fixes #16148 Fixes #13607 Right now cargo vendor only filters .gitattributes, .gitignore, and .git at the top level of each package. If these files exist in subdirectories, they don't get filtered. This causes problems when the vendored code gets checked into a git repo - git processes those files and modifies them, which breaks checksums. I ran into this when trying to vendor libssh2-sys. The .gitattributes file in libgit2/src/util/ was getting its line endings changed by git, causing checksum failures. ### How should we test and review this PR? This follows the atomic commit pattern: - First commit adds a test showing the current buggy behavior (test passes) - Second commit implements the fix and updates test assertions (test still passes) The fix uses components() to recursively check for .git directories (since they can appear at any path level like deep/nested/.git/config), while using file_name() for .gitattributes and .gitignore files. ### Additional context This should also help with #13607 since it filters .gitignore and .git recursively too. If people actually need git functionality in their vendored deps, they can add rules to their own .gitattributes at the root level.
Cargo downloads your Rust project’s dependencies and compiles your project.
To start using Cargo, learn more at The Cargo Book.
To start developing Cargo itself, read the Cargo Contributor Guide.
The Cargo binary distributed through with Rust is maintained by the Cargo team for use by the wider ecosystem. For all other uses of this crate (as a binary or library) this is maintained by the Cargo team, primarily for use by Cargo and not intended for external use (except as a transitive dependency). This crate may make major changes to its APIs.
Code documentation: https://doc.rust-lang.org/nightly/nightly-rustc/cargo/
Cargo requires the following tools and packages to build:
cargo and rustcgit (to clone this repository)Other requirements:
The following are optional based on your platform and needs.
pkg-config — This is used to help locate system packages, such as libssl headers/libraries. This may not be required in all cases, such as using vendored OpenSSL, or on Windows.
OpenSSL — Only needed on Unix-like systems and only if the vendored-openssl Cargo feature is not used.
This requires the development headers, which can be obtained from the libssl-dev package on Ubuntu or openssl-devel with apk or yum or the openssl package from Homebrew on macOS.
If using the vendored-openssl Cargo feature, then a static copy of OpenSSL will be built from source instead of using the system OpenSSL. This may require additional tools such as perl and make.
On macOS, common installation directories from Homebrew, MacPorts, or pkgsrc will be checked. Otherwise it will fall back to pkg-config.
On Windows, the system-provided Schannel will be used instead.
LibreSSL is also supported.
Optional system libraries:
The build will automatically use vendored versions of the following libraries. However, if they are provided by the system and can be found with pkg-config, then the system libraries will be used instead:
libcurl — Used for network transfers.libgit2 — Used for fetching git dependencies.libssh2 — Used for SSH access to git repositories.libz (AKA zlib) — Used by the above C libraries for data compression. (Rust code uses zlib-rs instead.)It is recommended to use the vendored versions as they are the versions that are tested to work with Cargo.
First, you'll want to check out this repository
git clone https://github.com/rust-lang/cargo.git cd cargo
With cargo already installed, you can simply run:
cargo build --release
Cargo is designed to be extensible with new subcommands without having to modify Cargo itself. See the Wiki page for more details and a list of known community-developed subcommands.
Cargo releases coincide with Rust releases. High level release notes are available as part of Rust's release notes. Detailed release notes are available in the changelog.
Found a bug? We'd love to know about it!
Please report all issues on the GitHub issue tracker.
See the Cargo Contributor Guide for a complete introduction to contributing to Cargo.
Cargo is primarily distributed under the terms of both the MIT license and the Apache License (Version 2.0).
See LICENSE-APACHE and LICENSE-MIT for details.
This product includes software developed by the OpenSSL Project for use in the OpenSSL Toolkit (https://www.openssl.org/).
In binary form, this product includes software that is licensed under the terms of the GNU General Public License, version 2, with a linking exception, which can be obtained from the upstream repository.
See LICENSE-THIRD-PARTY for details.